Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container: skip checking for files in non-existent directories. #3410

Merged
merged 1 commit into from Oct 29, 2023
Merged

container: skip checking for files in non-existent directories. #3410

merged 1 commit into from Oct 29, 2023

Conversation

filippog
Copy link
Contributor

Inspired by profile data from @brancz at https://pprof.me/5dfadaf/ and confirmed via strace. On cgroup v1 systems about half of Stat calls turn out to be for files within paths that don't exist.

I have also added very basic benchmarks for getSpecInternal.

@k8s-ci-robot
Copy link
Collaborator

Hi @filippog. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Collaborator

dims commented Oct 16, 2023

/ok-to-test

@dims
Copy link
Collaborator

dims commented Oct 16, 2023

@filippog please see broken test

image

@filippog
container: skip checking for files in non-existent directories.
9a30197 
Inspired by profile data from @brancz at https://pprof.me/5dfadaf/ and
confirmed via `strace`. On cgroup v1 systems about half of Stat calls
turn out to be for files within paths that don't exist.

I have also added very basic benchmarks for getSpecInternal.
@filippog
Copy link
Contributor Author

@filippog please see broken test

image

Thank you! Fixed

@iwankgb iwankgb merged commit d19df4f into google:master Oct 29, 2023
14 checks passed
@filippog filippog deleted the get-spec-stat-optimization branch October 29, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwankgb iwankgb iwankgb approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@filippog @k8s-ci-robot @dims @iwankgb