Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gcloud auth configure-docker documentation #26

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

sritchie
Copy link
Collaborator

Users need to complete this step to be able to push to the Container Registry. I believe that the error message tells you to do this if you hit a failure, but it's better to have it documented.

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   45.78%   45.78%           
=======================================
  Files          17       17           
  Lines        2728     2728           
=======================================
  Hits         1249     1249           
  Misses       1479     1479           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45b0c5...9ceb503. Read the comment docs.

Copy link
Collaborator

@ajslone ajslone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch here.

@sritchie sritchie merged commit 28a5ebf into master Jun 23, 2020
@sritchie sritchie deleted the sritchie/gcloud_auth_docs branch June 23, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants