Skip docker push if image exists remotely
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 13, 2020 09:17
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 47.60% 48.12% +0.51%
==========================================
Files 27 27
Lines 2836 2849 +13
==========================================
+ Hits 1350 1371 +21
+ Misses 1486 1478 -8
Continue to review full report at Codecov.
|
ajslone
approved these changes
Jul 13, 2020
|
|
||
| def _image_tag_for_project(project_id: str, image_id: str) -> str: | ||
|
|
There was a problem hiding this comment.
would having a tag parameter here that defaults to latest be more flexible than just include_tag? We don't really tag things differently now, but perhaps in the future.
|
|
||
| """ | ||
| image_tag = _image_tag_for_project(project_id, image_id, include_tag=False) | ||
| cmd = [ |
There was a problem hiding this comment.
should we pass the --project flag here to the gcloud command, as we have the project_id handy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
caliban.util.authandcaliban.docker.push. 100% coverage on the latter, woohoo!docker push. This saves some nice time during submission.I'll point this PR back at master once we merge #32; but this is based on the project refactor, so it looks cleanest when I point there for now.