Split --docker_run_args on white space
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split `--docker_run_args` on any white space (and not just single spaces). See <https://docs.python.org/3.8/library/stdtypes.html#str.split> for details. This does not introduce spurious empty arguments when multiple spaces are used to separate docker run args (as in `--volume a:b`, with two spaces), and also ignores leading and trailing spaces (as in ` -v a:b`). The latter should also help with the warning described in <https://caliban.readthedocs.io/en/latest/recipes/local_dir.html>, "[...] if you pass -v instead of --volume [...]" since it allows using `-v` if you add a space in front of it.
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 50.62% 50.44% -0.18%
==========================================
Files 28 28
Lines 2894 2894
==========================================
- Hits 1465 1460 -5
- Misses 1429 1434 +5
Continue to review full report at Codecov.
|
|
@eschnett , thank you for this, this is excellent! Who'd have known... I'm glad to see this new trick. I'll get this released shortly. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
--docker_run_argson any white space (and not just single spaces). See https://docs.python.org/3.8/library/stdtypes.html#str.split for details.This does not introduce spurious empty arguments when multiple spaces are used to separate docker run args (as in
--volume a:b, with two spaces), and also ignores leading and trailing spaces (as in-v a:b). The latter should also help with the warning described in https://caliban.readthedocs.io/en/latest/recipes/local_dir.html, "[...] if you pass -v instead of --volume [...]" since it allows using-vif you add a space in front of it.