Add structure to project and global calibanconfig schema #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sritchie
commented
Jul 24, 2020
| s.Optional("apt_packages", default=AptPackages.validate({})): | ||
| AptPackages, | ||
| # If present, Caliban will attempt to install Julia into the base container. | ||
| s.Optional("julia_version", default=None): |
There was a problem hiding this comment.
This one's for you, @eschnett . I'll open up a separate PR that integrates your Julia work into caliban.build and pulls the version from this key. What do you think?
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 50.62% 50.60% -0.02%
==========================================
Files 28 28
Lines 2894 2897 +3
==========================================
+ Hits 1465 1466 +1
- Misses 1429 1431 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR paves the way for project, user and shared configurations across Caliban builds.