Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing newline in Dockerfile #69

Closed
wants to merge 1 commit into from
Closed

Add missing newline in Dockerfile #69

wants to merge 1 commit into from

Conversation

eschnett
Copy link
Contributor

@eschnett eschnett commented Aug 2, 2020

Closes #68.

sritchie
sritchie reviewed Aug 2, 2020
View reviewed changes
Copy link
Collaborator

@sritchie sritchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think we actually want to put this new line into copy_command itself. I can take a look tomorrow AM. Thanks for the work here!

@ajslone
Copy link
Collaborator

ajslone commented Aug 3, 2020

@eschnett I made Sam's recommended change and merged this in, sorry for the delay on this, as I forgot to do it this morning.

@eschnett eschnett closed this Aug 7, 2020
@eschnett eschnett deleted the eschnett/dockerfile-newline branch August 7, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sritchie sritchie sritchie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing newlines in generated Dockerfile when using GCP credentials
3 participants
@eschnett @ajslone @sritchie