Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cloud_sql_proxy installation before code copy #87

Merged
merged 1 commit into from
Aug 23, 2020

Conversation

sritchie
Copy link
Collaborator

User code changes most frequently, so let's move the cloudsql installation before this step. @ajslone , what do you think?

@sritchie sritchie requested a review from ajslone August 21, 2020 04:51
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #87 into master will increase coverage by 0.08%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   54.23%   54.31%   +0.08%     
==========================================
  Files          31       31              
  Lines        3188     3183       -5     
==========================================
  Hits         1729     1729              
+ Misses       1459     1454       -5     
Impacted Files Coverage Δ
caliban/docker/build.py 32.71% <18.18%> (-1.08%) ⬇️
caliban/platform/gke/util.py 99.25% <0.00%> (+0.37%) ⬆️
caliban/platform/cloud/types.py 90.50% <0.00%> (+0.63%) ⬆️
caliban/util/auth.py 76.19% <0.00%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346209a...d9576f8. Read the comment docs.

Copy link
Collaborator

@ajslone ajslone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sritchie sritchie merged commit d18489b into master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants