Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs to reflect current base images, document how to specify custom base image #92

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

ajslone
Copy link
Collaborator

@ajslone ajslone commented Sep 24, 2020

This PR updates our docs to document our current base images, and document how to specify a custom base image in .calibanconfig.json

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #92 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   55.56%   55.53%   -0.04%     
==========================================
  Files          31       31              
  Lines        3180     3180              
==========================================
- Hits         1767     1766       -1     
- Misses       1413     1414       +1     
Impacted Files Coverage Δ
caliban/platform/gke/util.py 98.13% <0.00%> (-1.12%) ⬇️
caliban/platform/cloud/types.py 89.87% <0.00%> (-0.64%) ⬇️
caliban/util/fs.py 90.56% <0.00%> (+0.94%) ⬆️
caliban/util/auth.py 76.19% <0.00%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b09430...7ed709d. Read the comment docs.

Copy link
Collaborator

@sritchie sritchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, so good!

@ajslone ajslone merged commit 56f96e7 into master Sep 25, 2020
@ajslone ajslone deleted the aslone/base_image_docs branch September 25, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants