Skip to content
This repository has been archived by the owner on Nov 5, 2022. It is now read-only.

fixes parsing of angles in Path2d #23

Closed
wants to merge 5 commits into from
Closed

Conversation

Botz
Copy link

@Botz Botz commented May 14, 2019

If there is a path with an Arc the path couldn't be parsed.

I also fixed a bug with multiple m/M commands in an SVG path

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Botz
Copy link
Author

Botz commented May 14, 2019

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@Botz
Copy link
Author

Botz commented May 14, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jcgregorio
Copy link
Contributor

Thanks for the PR! Please make the changes to canvasv5.js and then generate canvas.js from that file by running:

make canvas.js

Also, can you add some tests that confirm the fix actually works?

Thanks,
-joe

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@Botz
Copy link
Author

Botz commented Jul 18, 2019

@jcgregorio Any news to this?

@hn3000
Copy link

hn3000 commented Sep 21, 2020

Any chance this might get published soon?

@Link2Twenty
Copy link

@jcgregorio are you still the person to go to for getting things merged?

@Botz Botz closed this Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants