Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_GetParents does not account for comments #46

Closed
GoodEveningMiss opened this issue Dec 18, 2015 · 2 comments
Closed

_GetParents does not account for comments #46

GoodEveningMiss opened this issue Dec 18, 2015 · 2 comments

Comments

@GoodEveningMiss
Copy link

https://github.com/google/capirca/blob/master/lib/naming.py#L213

All the other methods to retrieve or search for tokens strip off any potential comments and whitespace before making any comparison. _GetParents does not. Library could be improved in general by stripping off comments when parsing and saving it as its own attribute.

@GoodEveningMiss
Copy link
Author

@ankenyr
Copy link
Contributor

ankenyr commented Apr 3, 2017

This was in the last push d10959d

@ankenyr ankenyr closed this as completed Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants