Remove remaining dependencies on Cargo #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces `CargoResult` with anyhow's `Result`, and uses `SourceId` from cargo_lock instead. As far as I can tell, we lose 101 dependencies total :)
acmcarther
approved these changes
May 14, 2020
There was a problem hiding this comment.
It feels like there are a lot of different "result" crates in the rust ecosystem... I'm impressed with this one though judging from how minimal the impact on the code was.
It looks like this CI run only took 8 min 49 sec where before the average was 13 - 16 minutes, so this is a decent sized impact.
Thanks for another great change. I'll publish a release including this change now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
CargoResultwith anyhow'sResult, and usesSourceIdfrom cargo_lock instead.As far as I can tell, we lose 101 dependencies total :)