Updated windows platforms from gnu to msvc
#254
Conversation
|
I would prefer to submit @dae's PR, but I don't feel strongly about this, particularly if we're fixing an important breakage. I'll check in on both of these in a couple of hours and submit this one if there isn't forward movement. |
|
I would prefer to have that PR merged as well, the fix is quite small but yeah, I don't know when he'll be around next. There was a breakage in Definitely your call to make @acmcarther edit: Just trying to help 😅 |
|
Sorry for the delay, I've pushed Uebel's change into my branch as well. Please feel free to merge either - fixing the breaking build is more important than credit for a few character change. :-) edit: with Uebel needing to confirm the CLA on the other branch, merging this may be easier. |
from Uebel: google#254
|
@acmcarther #245 is ready to merge. Closing this ticket as a duplicate |
* switch to MSVC targets on Windows gnu has been removed in favour of MSVC in rules_rust, so cargo-raze will need to be updated to match: bazelbuild/rules_rust@dfce123 * Updated examples * add missing checksum update from Uebel: #254 * WORKSPACE needed to reflect date update of smoke-test.sh Co-authored-by: Andre Brisco <andre.brisco@gmail.com>
Not trying to steal the thunder from @dae but there is currently an incompatibility between
cargo-razeand head ofrules_rustThis PR is the same change as #245 but with updated smoke-tests (the only thing broken about the PR). I'd love to see this get merged (or #245 get updated and merged) and then a release be made.