settings.index_url can now be a path #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmcarther
requested changes
Oct 26, 2020
|
What's the situation here? Is this ready for re-review? |
|
No, I've had a busy week and haven't been able to get back to this since your last review. I'll have some time tomorrow to update this |
Merged
|
@acmcarther this is ready for review. |
GregBowyer
approved these changes
Nov 2, 2020
…ied on remote assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily to unblock other work I'm doing but it did reveal that
test_binary_dependencies_remote_genmodewas a test that relied on remote resources. This both makes the test more deterministic and much faster.