Cleanup #275
Merged
Cleanup #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
GregBowyer
approved these changes
Nov 1, 2020
impl/src/bin/cargo-raze.rs
Outdated
| // Clean out the "remote" directory and guarantee that it exists | ||
| if remote_dir.exists() { | ||
| for entry in glob::glob(&format!("{}/BUILD*.bazel", &remote_dir.display().to_string()))? { | ||
| for entry in glob::glob(&format!( |
There was a problem hiding this comment.
Nit: I am not the biggest fan of everything_all_in_one_place(at(all(times)), so_its_hard_to_read)
Maybe if its a cleanup:
let build_glob = format!("{}/BUILD*.bazel", remote_dir.display());
for entry in glob::glob(&build_glob)? {I also think the display().to_string() is a bit needless, either we want display semantics (aka just use the std::path::Display struct directly) or to_string_lossy() is a better fit
?
There was a problem hiding this comment.
Updated. I might have misread what you wrote, I stuck with std::path::Display but are you saying to_string_lossy is better?
There was a problem hiding this comment.
No I was more suggesting options
|
@GregBowyer this is ready for another review |
|
👍 LGTM |
|
@acmcarther this PR is ready for review |
dfreese
approved these changes
Nov 2, 2020
|
@dfreese done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work pulled out of #276
Changes:
settings::testingtosettings::teststo be consistent with other modulescargo fmt