Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace support examples #277

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Workspace support examples #277

merged 2 commits into from
Nov 25, 2020

Conversation

UebelAndre
Copy link
Collaborator

This is a followup of #276 which adds examples demonstrating the use of cargo workspaces. Only the final two commits in this PR are relevant. Please see #276 for details about anything before that.

@UebelAndre
Copy link
Collaborator Author

@acmcarther Following #276 being merged, I've rebased this and is also ready for review.

@acmcarther
Copy link
Member

This PR looks good to me. Are you planning to prepare an update to the README as well? That's probably more accessible to users than this set of examples.

@UebelAndre
Copy link
Collaborator Author

I can update the README in #302 which is a change that greatly improves the usability of cargo workspace support. Does that sound good?

@acmcarther
Copy link
Member

That sounds fine.

@acmcarther acmcarther merged commit 9c81414 into google:master Nov 25, 2020
@UebelAndre UebelAndre deleted the workspace-support-examples branch November 25, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants