New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the need for cargo on the host when running //:raze
#388
Conversation
@acmcarther If you could take a quick peak at this, it makes #384 correct 😅 |
) | ||
|
||
sh_binary( | ||
name = "raze", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not compatible with windows and probably shouldn't be the default "cargo-raze" target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What makes it incompatible? I thought Bazel expected windows users to have bash
installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess sh_binary rules work on windows if bash is installed:
I don't really feel strongly about this, but I suspect this is a step backward for window support. I'm not sure what doing this properly would look like. |
I unfortunately don't have a windows machine to try this out on but am happy to address any concerns if this doesn't work. The correct solution is likely a custom rule that outputs a batch file but I'm not sure |
I guess we'll be able to iterate on this once the windows presubmit targets are restored. (FYI: you should be able to see the build kite builds now) |
I can, thank you! Windows dev is just insanely time consuming since I don't know what I'm doing and can only test in the CI builds 😅 |
I forgot that I still have cargo installed on my machine when testing this scenario. The
//:raze
target should be a wrapper script that explicitly sets the needed environment variables for runningcargo-raze
without installing cargo components on the hostWith the following diff:
I'm still able to run raze in another workspace