Set links attribute #400
Merged
Set links attribute #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added to rules_rust in bazelbuild/rules_rust#480 and we started parsing out the metadata in cargo_raze in google#281 but didn't start populating it in generated BUILD files. This enables us to remove a hack in rules_rust where we try to infer the correct value for the `links` attribute if it wasn't set, based on the name, which in turn will allow us to remove the `crate_name` attribute completely.
acmcarther
approved these changes
Mar 18, 2021
wchargin
added a commit
to tensorflow/tensorboard
that referenced
this pull request
Apr 15, 2021
Summary: Upgrading past bazelbuild/rules_rust#643 requires upgrading `cargo-raze` to pull in google/cargo-raze#400. Happily, the upgrade is easy, so let’s get this out of the way. The `cargo-raze` upgrade is needed to set `links = "openssl"` on the build script for `openssl-sys`. All the other changes are cosmetic, just modifying comments and reordering `load` statements. To verify: ``` git show -a | grep '^[-+]' | grep -v '^\(---\|+++\)' | sort -u ``` wchargin-branch: rules-rust-20210414 wchargin-source: b5810154f767bd1191691f9ac6dd8be032624e10
wchargin
added a commit
to tensorflow/tensorboard
that referenced
this pull request
Apr 16, 2021
Summary: Upgrading past bazelbuild/rules_rust#643 requires upgrading `cargo-raze` to pull in google/cargo-raze#400. Happily, the upgrade is easy, so let’s get this out of the way. The `cargo-raze` upgrade is needed to set `links = "openssl"` on the build script for `openssl-sys`. All the other changes are cosmetic, just modifying comments and reordering `load` statements. To verify: ``` git show -a third_party/ | grep '^[-+]' | grep -v '^\(---\|+++\)' | sort -u ``` wchargin-branch: rules-rust-20210414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added to rules_rust in
bazelbuild/rules_rust#480 and we started parsing
out the metadata in cargo_raze in #281 but didn't start populating it in
generated BUILD files.
This enables us to remove a hack in rules_rust where we try to infer the
correct value for the
linksattribute if it wasn't set, based on thename, which in turn will allow us to remove the
crate_nameattributecompletely.