Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed regression for proc-macro crates #441

Merged
merged 8 commits into from
Aug 25, 2021
Merged

Fixed regression for proc-macro crates #441

merged 8 commits into from
Aug 25, 2021

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Aug 24, 2021

This fixes crates.bzl never having any crates defined in the _PROC_MACRO_DEPENDENCIES map.

This fixes a regression from #425 (or #282) and regenerates cargo-raze outputs (which should have been done on the merged commit).

This also fixes a regression in how BUILD files were rendered, resulting in buildifier defects. I cherry picked a change I had an another branch which is ahead of main and contains the fix. This change includes #393

Finally, this fixes another regression where extra_aliased_targets was being ignored.

@google-cla
Copy link

google-cla bot commented Aug 24, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

(Wow, the amount of regen makes these PRs kind of hard to review...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants