Add SHA-256 to the local_repositories

impl/src/bazel.rs

@@ -309,6 +309,7 @@ mod tests {
       additional_flags: Vec::new(),
       extra_aliased_targets: Vec::new(),
       data_attr: None,
+      sha256: None,
     }
   }
 
@@ -337,6 +338,7 @@ mod tests {
       additional_flags: Vec::new(),
       extra_aliased_targets: Vec::new(),
       data_attr: None,
+      sha256: None,
     }
   }
 

impl/src/context.rs

@@ -56,6 +56,7 @@ pub struct CrateContext {
   pub additional_flags: Vec<String>,
   pub extra_aliased_targets: Vec<String>,
   pub data_attr: Option<String>,
+  pub sha256: Option<String>,
 }
 
 #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Serialize)]

impl/src/metadata.rs

@@ -73,6 +73,7 @@ pub struct Package {
   pub targets: Vec<Target>,
   pub features: HashMap<String, Vec<FeatureOrDependency>>,
   pub manifest_path: String,
+  pub sha256: Option<String>,
 }
 
 #[derive(Debug, Clone, Deserialize, PartialEq, Eq)]
@@ -272,6 +273,9 @@ impl<'config> MetadataFetcher for CargoInternalsMetadataFetcher<'config> {
         features.insert(feature.clone(), features_or_dependencies.clone());
       }
 
+      // Cargo use SHA256 for checksum so we can use them directly
+      let sha256 = package.manifest().summary().checksum().and_then(|x| Some(x.to_string()));
+
       packages.push(Package {
         name: package.name().to_string(),
         version: package.version().to_string(),
@@ -284,6 +288,7 @@ impl<'config> MetadataFetcher for CargoInternalsMetadataFetcher<'config> {
         targets: targets,
         features: features,
         manifest_path: package.manifest_path().display().to_string(),
+        sha256: sha256,
       });
     }
 
@@ -321,6 +326,7 @@ fn default_dependency_field_use_default_features() -> bool {
   true
 }
 
+#[cfg(test)]
 pub mod testing {
   use super::*;
 
@@ -353,6 +359,7 @@ pub mod testing {
       targets: Vec::new(),
       features: HashMap::new(),
       manifest_path: String::new(),
+      sha256: None,
     }
   }
 

impl/src/planning.rs

@@ -309,7 +309,7 @@ impl<'fetcher> BuildPlannerImpl<'fetcher> {
       let licenses = load_and_dedup_licenses(license_str);
 
       let data_attr = possible_crate_settings.and_then(|s| s.data_attr.clone());
-
+  
       crate_contexts.push(CrateContext {
         pkg_name: own_package.name.clone(),
         pkg_version: own_package.version.clone(),
@@ -328,16 +328,14 @@ impl<'fetcher> BuildPlannerImpl<'fetcher> {
         additional_flags: additional_flags,
         extra_aliased_targets: extra_aliased_targets,
         data_attr: data_attr,
+        sha256: own_package.sha256.clone(),
       })
     }
 
     Ok(crate_contexts)
   }
 
   fn produce_targets(&self, package: &Package) -> CargoResult<Vec<BuildTarget>> {
-    let full_name = format!("{}-{}", package.name, package.version);
-    let partial_path = format!("{}/", full_name);
-    let partial_path_byte_length = partial_path.as_bytes().len();
     let mut targets = Vec::new();
     for target in package.targets.iter() {
       let manifest_pathbuf = PathBuf::from(&package.manifest_path);
@@ -416,14 +414,10 @@ fn load_and_dedup_licenses(licenses: &str) -> Vec<LicenseData> {
 mod tests {
   use super::*;
   use metadata::Metadata;
-  use metadata::MetadataFetcher;
   use metadata::ResolveNode;
   use metadata::testing::StubMetadataFetcher;
   use metadata::testing as metadata_testing;
   use settings::testing as settings_testing;
-  use hamcrest::core::expect;
-  use hamcrest::prelude::*;
-  use settings::RazeSettings;
 
   const ROOT_NODE_IDX: usize = 0;
 

impl/src/settings.rs

@@ -133,6 +133,7 @@ pub enum GenMode {
   Remote,
 }
 
+#[cfg(test)]
 pub mod testing {
   use super::*;
 

impl/src/templates/remote_crates.bzl.template

@@ -10,7 +10,10 @@ def {{workspace.gen_workspace_prefix}}_fetch_remote_crates():
         name = "{{workspace.gen_workspace_prefix}}__{{crate.pkg_name | slugify | replace(from="-", to="_")}}__{{crate.pkg_version | slugify | replace(from="-", to="_")}}",
         url = "https://crates-io.s3-us-west-1.amazonaws.com/crates/{{crate.pkg_name}}/{{crate.pkg_name}}-{{crate.pkg_version}}.crate",
         type = "tar.gz",
-        strip_prefix = "{{crate.pkg_name}}-{{crate.pkg_version}}",
+        {% if crate.sha256
+        %}sha256 = "{{crate.sha256}}",
+        {% endif
+        %}strip_prefix = "{{crate.pkg_name}}-{{crate.pkg_version}}",
         build_file = "{{workspace.workspace_path}}/remote:{{crate.pkg_name}}-{{crate.pkg_version}}.BUILD"
     )
 {% endfor %}