fix(panic): Fix panics caused by non-existent template paths #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in Keats/tera#819, there was a regression in how non-existent glob paths are handled. Previously, invalid globs would be expanded to the empty set, but now they lead to an error. Since this implementation just wants a bogus template directory, we just load the `Tera::default()` template. This should address google#545 Signed off by: Nick Groszewski <ngroszewski@google.com>
groszewn
pushed a commit
to tensorflow/tensorboard
that referenced
this pull request
Mar 31, 2023
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in Keats/tera#819, there was a regression in how non-existent glob paths are handled. Previously, invalid globs would be expanded to the empty set, but now they lead to an error.
Since this implementation just wants a bogus template directory, we just load the
Tera::default()template.This should address #545