Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken smoke-test.sh #82

Merged
merged 3 commits into from Jan 10, 2019
Merged

Fix Broken smoke-test.sh #82

merged 3 commits into from Jan 10, 2019

Conversation

acmcarther
Copy link
Member

@acmcarther acmcarther commented Jan 9, 2019

Related:
#80
#81

Waiting on #81 to finish and get submitted.


It seems smoke tests were broken in a variety of ways, some of which are really inexplicable:

  1. non_cratesio_library's futures dependency was plainly not compatible with the code. It was trying to use a version of futures that didn't have functions it needed. CI for the PR that made the most recent changes passed, so perhaps we have some kind of caching issue?
  2. The workspace name for the example workspace was the same as rules_rust. This apparently confuses Bazel greatly on newer versions of Bazel (but not older ones?)
  3. Per the original PR name in smoke-test.sh bazel build X && bazel build Y causes failures in the build of X to not trigger the set -e behavior.

@acmcarther acmcarther changed the title Run blaze build commands independently so that 'set -e' properly fails Run bazel build commands independently so that 'set -e' properly fails Jan 9, 2019
@acmcarther
Copy link
Member Author

[23 / 24] Compiling Rust bin non_cratesio_library (1 files); 0s linux-sandbox
error[E0432]: unresolved import `futures::executor::block_on`
 --> vendored/non_cratesio_library/src/main.rs:7:5
  |
7 | use futures::executor::block_on;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `block_on` in `executor`

No idea what is going on here. It doesn't make sense for this to fail separately from current master, given the change in this CL, and it doesn't really make sense for it to be failing at all since futures in this example is from git, at a specific tagged release: "0.1.19".

I'll figure out what's going on with this example and update this PR some time today.

@acmcarther acmcarther changed the title Run bazel build commands independently so that 'set -e' properly fails Fix Broken smoke-test.sh Jan 10, 2019
@acmcarther acmcarther merged commit 1271536 into master Jan 10, 2019
@acmcarther acmcarther deleted the acm-fix-ci branch January 10, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant