Skip to content

Commit

Permalink
Remove even more Fatal* calls
Browse files Browse the repository at this point in the history
  • Loading branch information
andrew-d committed Apr 15, 2015
1 parent 1990eba commit 7de923d
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 9 deletions.
17 changes: 11 additions & 6 deletions appengine/appengine.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package main

import (
"fmt"
"github.com/barakmich/glog"
"os"
"time"
Expand Down Expand Up @@ -45,11 +46,11 @@ var (
timeout = 30 * time.Second
)

func configFrom(file string) *config.Config {
func configFrom(file string) (*config.Config, error) {
// Find the file...
if file != "" {
if _, err := os.Stat(file); os.IsNotExist(err) {
glog.Fatalln("Cannot find specified configuration file", file, ", aborting.")
return nil, fmt.Errorf("Cannot find specified configuration file", file)
}
} else if _, err := os.Stat("/cayley_appengine.cfg"); err == nil {
file = "/cayley_appengine.cfg"
Expand All @@ -59,7 +60,7 @@ func configFrom(file string) *config.Config {
}
cfg, err := config.Load(file)
if err != nil {
glog.Fatalln(err)
return nil, err
}

if cfg.DatabasePath == "" {
Expand Down Expand Up @@ -92,15 +93,19 @@ func configFrom(file string) *config.Config {

cfg.ReadOnly = cfg.ReadOnly || readOnly

return cfg
return cfg, nil
}

func init() {
glog.SetToStderr(true)
cfg := configFrom("cayley_appengine.cfg")
cfg, err := configFrom("cayley_appengine.cfg")
if err != nil {
glog.Fatalln("Error loading config:", err)
}

handle, err := db.Open(cfg)
if err != nil {
glog.Fatal(err)
glog.Fatalln("Error opening database:", err)
}
http.SetupRoutes(handle, cfg)
}
2 changes: 1 addition & 1 deletion graph/gaedatastore/quadstore.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ func getContext(opts graph.Options) (appengine.Context, error) {
req := opts["HTTPRequest"].(*http.Request)
if req == nil {
err := errors.New("HTTP Request needed")
glog.Fatalln(err)
glog.Errorln(err)
return nil, err
}
return appengine.NewContext(req), nil
Expand Down
5 changes: 3 additions & 2 deletions graph/primarykey.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,9 @@ func (p *PrimaryKey) Int() int64 {
case sequential:
return p.sequentialID
case unique:
glog.Fatal("UUID cannot be cast to an int64")
return -1
msg := "UUID cannot be cast to an int64"
glog.Errorln(msg)
panic(msg)
}
return -1
}
Expand Down

0 comments on commit 7de923d

Please sign in to comment.