Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added example n-quad file for gremlin api description #237

Merged
merged 4 commits into from Apr 25, 2015

Conversation

jf87
Copy link

@jf87 jf87 commented Apr 21, 2015

Just felt it was useful to have the example graph used in https://github.com/google/cayley/blob/master/docs/GremlinAPI.md to try out the described queries by loading the graph into cayley.

@barakmich
Copy link
Member

Good idea, but I think we should push it slightly to be more awesome.

  1. Perhaps it's time to have a /data directory, with some of the example datafiles (that are currently in root), this one included.
  2. This file (sort of) exists as query/gremlin/gremlin_test.nt -- yours should become canonical and the gremlin test should be modified slightly to use it (changing cool to cool_person and the load path in the gremlin test)
  3. Add a few lines to GremlinAPI.md on "play around with this simple graph using the command...."
  4. All documentation referring to datasets in root now refer to them in the data dir.

This also opens the door for other data sets, some data set integration/benchmark tests and so on. In short, really useful :)

@jf87
Copy link
Author

jf87 commented Apr 21, 2015

Sounds good :-)
I could do this during the next days and add it to this pull request.

@barakmich
Copy link
Member

Awesome. Totally a great first PR with some improvements in a few corners :)

gremlin_test.nt is not necessary anymore
-- actually it was not used before ;-)
@jf87
Copy link
Author

jf87 commented Apr 23, 2015

I've added the above changes now. Let me know what you think :-)

// Results in three paths for B (from A C and D)
g.V().Out("follows").Is("B")
// Starting from all nodes in the graph, find the paths that follow bob.
// Results in three paths for bob (from alic, charlie and dani)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alice

@barakmich
Copy link
Member

LGTM. Merging.

We were super impressed in the office that you went to the trouble to correct the ASCII art :)

barakmich added a commit that referenced this pull request Apr 25, 2015
added example n-quad file for gremlin api description
@barakmich barakmich merged commit 7fa20fc into cayleygraph:master Apr 25, 2015
@jf87
Copy link
Author

jf87 commented Apr 26, 2015

Haha, I had already started to change the names when I remembered the ASCII graph, so I had to go through with it as well :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants