Stop trimming "redundant" trailing transitions. #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even when the last two transitions share a type, we should not discard the last transition as that might change the point at which we start to apply the POSIX spec for future transitions. This will start to make a difference in zoneinfo files compiled using the 2023d zic for Antarctica/Macquarie, Europe/Riga, Europe/Tallinn, Europe/Vilnius, and Pacific/Norfolk, where we previously would have added daylight-time transitions in years where they did not really apply.
derekmauro
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when the last two transitions share a type, we should not discard the last transition as that might change the point at which we start to apply the POSIX spec for future transitions.
This will start to make a difference in zoneinfo files compiled using the 2023d zic for Antarctica/Macquarie, Europe/Riga, Europe/Tallinn, Europe/Vilnius, and Pacific/Norfolk, where we previously would have added daylight-time transitions in years where they did not really apply.