Add new flags to asset stream manager #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config_dir defines a directory with assets_stream_manager.json configuration file for assets stream manager.
chrschng
previously requested changes
Nov 21, 2022
ljusten
previously approved these changes
Nov 21, 2022
ljusten
requested changes
Nov 21, 2022
ljusten
requested changes
Nov 22, 2022
ljusten
approved these changes
Nov 22, 2022
ljusten
dismissed
chrschng’s stale review
Christian's remark was covered, not sure why it still says "change requested".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--log_dir - directory for log files
--config-dir - directory for the configuration file assets_stream_manager.json
In addition, remove unused functions from SdkUtils and fix build issue with cdc_fuse_fs