-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new flags to asset stream manager #10
Conversation
config_dir defines a directory with assets_stream_manager.json configuration file for assets stream manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Lena! I have only one small suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few minor remarks. Thanks!
Christian's remark was covered, not sure why it still says "change requested".
--log_dir - directory for log files
--config-dir - directory for the configuration file assets_stream_manager.json
In addition, remove unused functions from SdkUtils and fix build issue with cdc_fuse_fs