Fix ANTLR related data-race. #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimLarson
approved these changes
Mar 5, 2019
| @@ -852,6 +852,7 @@ func TestParse(t *testing.T) { | |||
| for i, tst := range testCases { | |||
| name := fmt.Sprintf("%d %s", i, tst.I) | |||
| t.Run(name, func(tt *testing.T) { | |||
| tt.Parallel() | |||
There was a problem hiding this comment.
Add a comment explaining why it's important to parallelize here.
| @@ -1127,6 +1127,7 @@ func TestCheck(t *testing.T) { | |||
| for i, tst := range testCases { | |||
| name := fmt.Sprintf("%d %s", i, tst.I) | |||
| t.Run(name, func(tt *testing.T) { | |||
| tt.Parallel() | |||
There was a problem hiding this comment.
Add a comment explaining why we parallelize here.
TristonianJones
force-pushed
the
data-race-fix
branch
from
a65b50b
to
6d0ba9d
Compare
This was referenced Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #175 pointed out a data race within the parser which occurs when the parsing is run in parallel. The issue appears to be related to the ANTLR Go Codegen which creates mutable global variables during parser generation.
The best available fix, shy of addressing the Go codegen and ANLTR Go runtime libraries, is to make the global state per-instance. This will likely have a performance impact, but it's difficult to characterize at this time.