Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codelab module and codelab refactors #567

merged 5 commits into from Jul 15, 2022


Copy link

Update the codelab to be its own go-module and refactor the codelab solution to use
the latest features such as cel.Variable and cel.Function which both simplify the code
and perform more of the boilerplate tasks in the core CEL library rather than in user-
provided extensions.

Will update the public codelab to match post-submission as part of fixes for #553

l46kok previously approved these changes Jul 15, 2022
Copy link

@l46kok l46kok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also update the examples with this new syntax? Either in this or in a separate PR

Copy link
Collaborator Author

@l46kok good catch on updating the examples as well. Done.

examples/ Outdated Show resolved Hide resolved
examples/ Outdated Show resolved Hide resolved
@TristonianJones TristonianJones merged commit 52567e2 into google:master Jul 15, 2022
2 checks passed
@TristonianJones TristonianJones deleted the codelab-module branch July 15, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants