Update presence test state tracking and pruning #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristonianJones
force-pushed
the
unknowns-presence-test-fix-b
branch
2 times, most recently
from
3e97648
to
da0bde9
Compare
The has() macro calls were not being adequately captured during state tracking which led to issues in cost estimation and ast pruning function. The updated behavior ensures that the has() macro calls have the same cost as a traditional select expression and that the state for the presence test is correctly recorded in a way that works with partial evaluation.
TristonianJones
force-pushed
the
unknowns-presence-test-fix-b
branch
from
da0bde9
to
d45a756
Compare
jcking
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The has() macro calls were not being adequately captured during
state tracking which led to issues in cost estimation and ast
pruning function. The updated behavior ensures that the has()
macro calls have the same cost as a traditional select expression
and that the state for the presence test is correctly recorded
in a way that works with partial evaluation.