Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility and SEO improvements #21

Merged
merged 5 commits into from Oct 28, 2021
Merged

Accessibility and SEO improvements #21

merged 5 commits into from Oct 28, 2021

Conversation

jcabak
Copy link
Contributor

@jcabak jcabak commented Apr 7, 2021

  • Image elements have [alt] attributes
  • Background and foreground colors have a sufficient contrast ratio

Lighthouse score is now much better
d

Copy link
Member

@AlCutter AlCutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for taking the time to raise this PR, Jakub!
I'm sorry it's taken a long while to get a response.

assets/scss/colors.scss Outdated Show resolved Hide resolved
@jcabak jcabak requested a review from AlCutter October 28, 2021 11:08
Copy link
Member

@AlCutter AlCutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tiny capitalisation nits I spotted...

<p>
Or get started by going to the <a href='{{< siteparams "githubUrl" >}}'>GitHub page</a><br/>
or joining the <a href='{{<siteparams "googlegroup" >}}'>Google Group.</a></p>
Or get started by going to the <a href='{{< siteparams "githubUrl" >}}' title="Certificate Transparency Github">GitHub page</a><br/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Github -> GitHub

</ul>
</li>
<li>
<ul>
<li><a href="{{ .Site.Params.githubUrl }}">GitHub</a></li>
<li><a href="{{ .Site.Params.googlegroup}}">Google Group</a></li>
<li><a href="{{ .Site.Params.githubUrl }}" title="Certificate Transparency Github">GitHub</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(GitHub)

<li class='user_agents'><a href='{{ "/useragents" | relURL}}'>User Agents</a></li>
<li class='logs'><a href='{{ "/logs" | relURL}}' title="Certificate Transparency Logs">Logs</a></li>
<li class='monitors'><a href='{{ "/monitors" | relURL}}' title="Certificate Transparency Monitors">Monitors</a></li>
<li class='user_agents'><a href='{{ "/useragents" | relURL}}' title="Certificate Transparency user Agents">User Agents</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user -> User

</ul>
<ul class="elsewhere">
<li class='github'><a href="{{ .Site.Params.githubUrl }}">GitHub</a></li>
<li class='ggroup'><a href="{{ .Site.Params.googlegroup}}">Google Group</a></li>
<li class='github'><a href="{{ .Site.Params.githubUrl }}" title="Certificate Transparency Github">GitHub</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(GitHub)

Copy link
Contributor Author

@jcabak jcabak Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your vigilance! Fixed.

@AlCutter AlCutter merged commit ccc07b1 into google:master Oct 28, 2021
@AlCutter
Copy link
Member

Thanks again, Jakub!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants