New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility and SEO improvements #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for taking the time to raise this PR, Jakub!
I'm sorry it's taken a long while to get a response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few tiny capitalisation nits I spotted...
content/home/index.html
Outdated
<p> | ||
Or get started by going to the <a href='{{< siteparams "githubUrl" >}}'>GitHub page</a><br/> | ||
or joining the <a href='{{<siteparams "googlegroup" >}}'>Google Group.</a></p> | ||
Or get started by going to the <a href='{{< siteparams "githubUrl" >}}' title="Certificate Transparency Github">GitHub page</a><br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Github -> GitHub
</ul> | ||
</li> | ||
<li> | ||
<ul> | ||
<li><a href="{{ .Site.Params.githubUrl }}">GitHub</a></li> | ||
<li><a href="{{ .Site.Params.googlegroup}}">Google Group</a></li> | ||
<li><a href="{{ .Site.Params.githubUrl }}" title="Certificate Transparency Github">GitHub</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(GitHub)
layouts/partials/topnav.html
Outdated
<li class='user_agents'><a href='{{ "/useragents" | relURL}}'>User Agents</a></li> | ||
<li class='logs'><a href='{{ "/logs" | relURL}}' title="Certificate Transparency Logs">Logs</a></li> | ||
<li class='monitors'><a href='{{ "/monitors" | relURL}}' title="Certificate Transparency Monitors">Monitors</a></li> | ||
<li class='user_agents'><a href='{{ "/useragents" | relURL}}' title="Certificate Transparency user Agents">User Agents</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user -> User
layouts/partials/topnav.html
Outdated
</ul> | ||
<ul class="elsewhere"> | ||
<li class='github'><a href="{{ .Site.Params.githubUrl }}">GitHub</a></li> | ||
<li class='ggroup'><a href="{{ .Site.Params.googlegroup}}">Google Group</a></li> | ||
<li class='github'><a href="{{ .Site.Params.githubUrl }}" title="Certificate Transparency Github">GitHub</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(GitHub)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your vigilance! Fixed.
Thanks again, Jakub! |
[alt]
attributesLighthouse score is now much better