Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manual deploy docs #1061

Merged
merged 6 commits into from
Apr 27, 2023
Merged

Update manual deploy docs #1061

merged 6 commits into from
Apr 27, 2023

Conversation

AlCutter
Copy link
Member

Fix a few bits in the manual deploy docs where things have drifted over time.
Also add some explicit/example go run commands to help folks get something running.

For #1060.

Checklist

@roger2hk
Copy link
Contributor

Thanks @AlCutter for updating the doc. I will approve this PR after I have tried each step in the manual deploy doc.

mhutchinson added a commit to mhutchinson/certificate-transparency-go that referenced this pull request Apr 25, 2023
The previous instructions have rotted and no longer work. This aims to fill in the gap of a HelloWorld deployment for CTFE. This is explicitly NOT a guide on how to deploy this in a production setting. This is a docker version of the updated instructions from google#1061
Co-authored-by: Martin Hutchinson <mhutchinson@gmail.com>
@roger2hk
Copy link
Contributor

@mhutchinson I'm not sure why but your CLA is missing.

@roger2hk
Copy link
Contributor

The demo script mentioned in ManualDeployment.md no longer works when module is enabled by default in Go.

if [[ ${PWD} -ef ${GOPATH}/src/github.com/google/certificate-transparency-go/trillian/integration ]]; then

➜ /workspaces/certificate-transparency-go (master) $ ls /go/pkg/mod/github.com/google
btree@v1.1.2  go-cmp@v0.5.9  trillian@v1.5.1  uuid@v1.3.0

@roger2hk
Copy link
Contributor

The command changes in this PR work like a charm.

@mhutchinson
Copy link
Contributor

@mhutchinson I'm not sure why but your CLA is missing.

Yeah that's weird. Did I make it onto the CLA list because I suggested a change in the UI and thus it isn't really "from" me, but the GitHub UI as a proxy?

@AlCutter not sure how to work around this with CLA bot. Maybe just "redo" the changes in that last commit in such a way that I never existed. I won't be offended.

@roger2hk
Copy link
Contributor

@mhutchinson I'm not sure why but your CLA is missing.

Yeah that's weird. Did I make it onto the CLA list because I suggested a change in the UI and thus it isn't really "from" me, but the GitHub UI as a proxy?

@AlCutter not sure how to work around this with CLA bot. Maybe just "redo" the changes in that last commit in such a way that I never existed. I won't be offended.

@mhutchinson It might be easier if you sign the CLA at https://cla.developers.google.com using mhu******on​@gmail.com.

@roger2hk
Copy link
Contributor

Thanks @mhutchinson. The CLA check passes now.

@roger2hk roger2hk merged commit f8d22bf into google:master Apr 27, 2023
4 checks passed
roger2hk pushed a commit to mhutchinson/certificate-transparency-go that referenced this pull request Apr 30, 2023
The previous instructions have rotted and no longer work. This aims to fill in the gap of a HelloWorld deployment for CTFE. This is explicitly NOT a guide on how to deploy this in a production setting. This is a docker version of the updated instructions from google#1061
roger2hk added a commit that referenced this pull request Apr 30, 2023
* Docker compose config for demo CTFE

The previous instructions have rotted and no longer work. This aims to fill in the gap of a HelloWorld deployment for CTFE. This is explicitly NOT a guide on how to deploy this in a production setting. This is a docker version of the updated instructions from #1061

* Use ctclient instead of curl

* Add container_name for ctfe-db in docker-compose.yaml

* Update ctfe-db container name in README.md

---------

Co-authored-by: Roger Ng <rogerng@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants