Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build the ctfe/ct_server binary without depending on glibc #1119

Merged
merged 1 commit into from Aug 2, 2023
Merged

Build the ctfe/ct_server binary without depending on glibc #1119

merged 1 commit into from Aug 2, 2023

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented Aug 2, 2023

Fixes #1118.

Here is the distroless Dockerfile example for Go.
https://github.com/GoogleContainerTools/distroless/blob/main/examples/go/Dockerfile

Checklist

@roger2hk roger2hk marked this pull request as ready for review August 2, 2023 16:05
@roger2hk roger2hk requested a review from a team as a code owner August 2, 2023 16:05
@roger2hk
Copy link
Contributor Author

roger2hk commented Aug 2, 2023

/gcbrun

mhutchinson
mhutchinson approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. May be that we also need to do the same for trillian too?

@roger2hk
Copy link
Contributor Author

roger2hk commented Aug 2, 2023

Nice one. May be that we also need to do the same for trillian too?

Sure, let me get them fixed after merging this one. The CI certificate-transparency-go-cloud-build-pull-request (trillian-opensource-ci) is broken... 😕

@roger2hk roger2hk merged commit f1db8e3 into google:master Aug 2, 2023
4 checks passed
@roger2hk roger2hk deleted the fix-ctfe-image branch August 2, 2023 17:41
@roger2hk
Copy link
Contributor Author

roger2hk commented Aug 9, 2023

According to GoogleContainerTools/distroless#1342, updating the CGO_ENABLED is not appropriate to resolve the issue. The gcr.io/distroless/base Docker image is supposed to include glibc.

@roger2hk roger2hk mentioned this pull request Nov 6, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhutchinson mhutchinson mhutchinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CTFE GLIBC Error
2 participants
@roger2hk @mhutchinson