CTFE Extra Data Issuance Chain Deduplication #1477

roger2hk · 2024-05-12T23:55:32Z

This CTFE extra data issuance chain deduplication contributes to #691.

Checklist

I have updated the CHANGELOG.
- Adjust the draft version number according to semantic versioning rules.
I have updated documentation accordingly.

roger2hk · 2024-05-12T23:58:02Z

MySQL integration to be added into the Cloud Build integration test.

trillian/ctfe/handlers.go

phbnf

First round of reviews on code structure flags. I'm interested to know what others think about this as well. I'll have another look looking closer at the processing of chains itself.

CHANGELOG.md

trillian/ctfe/cache/cache.go

trillian/ctfe/handlers.go

trillian/ctfe/instance.go

trillian/ctfe/services.go

trillian/util/log_leaf.go

CHANGELOG.md

trillian/ctfe/cache/cache.go

trillian/ctfe/handlers.go

trillian/ctfe/services.go

trillian/ctfe/handlers.go

… and `rpcGetEntryAndProof`

…nfig in integration test flow

trillian/ctfe/instance.go

trillian/ctfe/services.go

trillian/util/log_leaf.go

trillian/ctfe/services.go

trillian/ctfe/cache/cache.go

trillian/util/log_leaf.go

trillian/ctfe/services.go

…gument

CTFE Extra Data Issuance Chain Deduplication

02eebc9

roger2hk requested review from mhutchinson, phbnf and AlCutter May 12, 2024 23:55

roger2hk requested a review from a team as a code owner May 12, 2024 23:55

roger2hk commented May 13, 2024

View reviewed changes

trillian/ctfe/handlers.go Outdated Show resolved Hide resolved

Add CT server with MySQL configuration example

6814ecb

phbnf reviewed May 13, 2024

View reviewed changes

roger2hk added 7 commits May 13, 2024 12:19

Update CTFE storage saving changelog

29bdc2a

Fix always if true condition

6948124

Reuse IsCTFEStorageEnabled

041f07d

Setting default cache size and ttl to -1

f86cf76

Add code comments for issuanceChainStorage and issuanceChainCache

d632250

Fix incorrect NewIssuanceChainCache comment

6f5c6de

Refactor addChainInternal and remove buildLogLeafForAddChain

0350d94

roger2hk requested a review from phbnf May 14, 2024 21:51

mhutchinson reviewed May 15, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

trillian/ctfe/cache/cache.go Outdated Show resolved Hide resolved

trillian/ctfe/handlers.go Outdated Show resolved Hide resolved

trillian/ctfe/services.go Show resolved Hide resolved

roger2hk added 4 commits May 15, 2024 17:26

Move cache flags to ct_server main

9b43c56

Remove TODO comment for []ct.ASN1Cert to []byte conversion

2e05680

Add FixLogLeaf method comment

2aa94b1

Return err in GetByHash and Add when storage is nil

e4a8b77

phbnf reviewed May 16, 2024

View reviewed changes

trillian/ctfe/handlers.go Outdated Show resolved Hide resolved

roger2hk added 7 commits May 16, 2024 10:09

Enable MySQL in ct server test

f05e1a8

Refactor log leaf build logic

573c9cb

Fix leaf var scope bug

d11912b

Rename method from public Add to private add

3168c3b

Refactor issuanceChainService.FixLogLeaf into rpcGetLeavesByRange…

1c3bf0b

… and `rpcGetEntryAndProof`

Add rpcGetLeavesByRange and rpcGetEntryAndProof method comment

b51e8db

Add more information in CHANGELOG.md

7e0f5b0

roger2hk added 15 commits May 17, 2024 19:32

Add mariadb-client to ct_testbase Dockerfile

3e68a91

Update comment

4c93e3f

Export MYSQL_HOST in ct_functions.sh

d08c7f4

Export MYSQL_ROOT_PASSWORD in ct_functions.sh

1723da3

Export MYSQL_USER_HOST in ct_functions.sh

783d697

Add all combination of extra_data_issuance_chain_storage_backend co…

77093a0

…nfig in integration test flow

Unexport MYSQL_USER_HOST for debugging

b8b65ac

Revert: Unexport MYSQL_USER_HOST for debugging

75ea5f5

Add debug log to resectdb.sh

f018e5d

Add "SHOW TABLES" in debug log

fbf800f

Add USE ${MYSQL_DATABASE}; SHOW TABLES;

0f4007e

Move CT test database reset to GCB step 3 (ci-ready)

9bf4ce4

Fix missing $ in cloudbuild.yaml

6b187d3

Reset CT test database in cloudbuild_master.yaml

fe2c8a0

Update CHANGELOG.md

a55b3be

mhutchinson approved these changes May 20, 2024

View reviewed changes

trillian/ctfe/instance.go Outdated Show resolved Hide resolved

trillian/ctfe/services.go Outdated Show resolved Hide resolved

AlCutter approved these changes May 20, 2024

View reviewed changes

trillian/util/log_leaf.go Outdated Show resolved Hide resolved

trillian/ctfe/services.go Show resolved Hide resolved

trillian/ctfe/cache/cache.go Show resolved Hide resolved

roger2hk added 5 commits May 20, 2024 15:03

Remove duplicated comment

60b0866

Rename hash to chainHash

974e925

Unexport isCTFEStorageEnabled method

7bf9a52

Add comments for type/struct

f6e7f4a

Add code comment about the way we unmarshal leaf.ExtraData

1a6afe9

phbnf reviewed May 21, 2024

View reviewed changes

trillian/util/log_leaf.go Outdated Show resolved Hide resolved

trillian/util/log_leaf.go Outdated Show resolved Hide resolved

trillian/util/log_leaf.go Show resolved Hide resolved

trillian/ctfe/services.go Outdated Show resolved Hide resolved

trillian/ctfe/services.go Show resolved Hide resolved

roger2hk added 4 commits May 21, 2024 19:44

Rename method to ExtraDataForChainHash and remove unused chain ar…

7265f99

…gument

Remove unused chain argument

8a90534

Update FixLogLeaf method comment

e65d8f5

Add buildLogLeaf method comment

1dd7f10

phbnf approved these changes May 22, 2024

View reviewed changes

roger2hk merged commit a3fb01e into google:master May 22, 2024
6 checks passed

roger2hk deleted the extra-data-issuance-chain branch May 22, 2024 16:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CTFE Extra Data Issuance Chain Deduplication #1477

CTFE Extra Data Issuance Chain Deduplication #1477

roger2hk commented May 12, 2024

roger2hk commented May 12, 2024

phbnf left a comment

CTFE Extra Data Issuance Chain Deduplication #1477

CTFE Extra Data Issuance Chain Deduplication #1477

Conversation

roger2hk commented May 12, 2024

Checklist

roger2hk commented May 12, 2024

phbnf left a comment

Choose a reason for hiding this comment