Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect proto copying for client multilog config. #558

Merged
merged 1 commit into from Jul 2, 2019

Conversation

Martin2112
Copy link
Contributor

Slight API tweak that affects preloader.

Slight API tweak that affects preloader.
@Martin2112
Copy link
Contributor Author

Martin2112 commented Jul 2, 2019

Towards github.com/google/trillian#1738.

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #558 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
- Coverage   71.57%   71.53%   -0.05%     
==========================================
  Files          90       90              
  Lines        9693     9693              
==========================================
- Hits         6938     6934       -4     
- Misses       2265     2267       +2     
- Partials      490      492       +2
Impacted Files Coverage Δ
client/multilog.go 65.71% <100%> (ø) ⬆️
submission/races.go 81.67% <0%> (-3.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc05c79...2871ae8. Read the comment docs.

@Martin2112 Martin2112 merged commit a7eaa3b into google:master Jul 2, 2019
@Martin2112 Martin2112 deleted the fix_temporal_config_proto branch July 2, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants