Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip consistency check when root is size zero #960

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

hickford
Copy link
Contributor

@hickford hickford commented Jul 27, 2022

Any head is consistent with empty root.

Checklist

Any head is consistent with empty root.
@hickford hickford marked this pull request as ready for review July 27, 2022 09:25
@hickford hickford requested a review from a team as a code owner July 27, 2022 09:25
@hickford hickford requested review from zkpjedi and removed request for a team July 27, 2022 09:25
@hickford hickford marked this pull request as draft July 27, 2022 09:30
@hickford hickford marked this pull request as ready for review July 27, 2022 12:35
@hickford hickford marked this pull request as draft July 27, 2022 12:35
@hickford hickford marked this pull request as ready for review July 28, 2022 09:16
@hickford hickford marked this pull request as draft July 28, 2022 09:26
@hickford hickford marked this pull request as ready for review July 28, 2022 14:55
@hickford hickford merged commit 746a8a5 into google:master Aug 1, 2022
@hickford
Copy link
Contributor Author

hickford commented Aug 3, 2022

Motivation: some logs reject get-sth-consistency requests with first=0.

> http get "https://yeti2022-2.ct.digicert.com/log/ct/v1/get-sth-consistency?first=0&second=1"
HTTP/1.1 400 BAD REQUEST

while other logs respond with an empty proof:

> http get "https://oak.ct.letsencrypt.org/2022/ct/v1/get-sth-consistency?first=0&second=1"
HTTP/1.1 200 OK
{
    "consistency": []
}

The RFC doesn't guarantee at STH at size 0 exists https://datatracker.ietf.org/doc/html/rfc6962#section-4.4

Both tree sizes must be from existing v1 STHs (Signed Tree Heads).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants