Switch from glog to klog #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should pull in latest trillian once this is merged: google/trillian#2787 |
|
/gcbrun |
AlCutter
force-pushed
the
switch-to-klog
branch
from
aa7ede9
to
900194f
Compare
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
AlCutter
force-pushed
the
switch-to-klog
branch
from
900194f
to
7452f80
Compare
|
/gcbrun |
AlCutter
force-pushed
the
switch-to-klog
branch
from
7452f80
to
ef3d0f6
Compare
|
/gcbrun |
dlorenc
approved these changes
Aug 20, 2022
|
Not that mine counts for anything, lgtm :) |
zkpjedi
approved these changes
Aug 20, 2022
|
Thanks Al! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the following explanation of the reasons for klog vs. glog: https://github.com/kubernetes/klog#why-was-klog-created