Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Ben Kaduk's final comments: #339

Merged
merged 2 commits into from Jul 30, 2021
Merged

Ben Kaduk's final comments: #339

merged 2 commits into from Jul 30, 2021

Conversation

richsalz
Copy link
Contributor

  • Change Expert Review to Specification Required in one section
  • Use requested OID in the ASN1 module
  • Fix whitespace, add a comma

- Change Expert Review to Specification Required in one section
- Use requested OID in the ASN1 module
- Fix whitespace, add a comma
@google-cla
Copy link

google-cla bot commented Jul 29, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@paulwouters
Copy link

Looks good to be, Rob please merge and push a new draft out

draft-ietf-trans-rfc6962-bis.md Outdated Show resolved Hide resolved
draft-ietf-trans-rfc6962-bis.md Outdated Show resolved Hide resolved
Fix typo.

Co-authored-by: kaduk <kaduk-github@mit.edu>
@google-cla
Copy link

google-cla bot commented Jul 30, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@robstradling robstradling merged commit ae3fd1b into google:master Jul 30, 2021
@richsalz richsalz deleted the kaduk-final branch July 30, 2021 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants