This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Use absl.app in print_log_list.py and improve flag checks #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pphaneuf
previously approved these changes
Sep 7, 2018
RJPercival
force-pushed
the
log_list_app
branch
from
a3750f1
to
ffb14cd
Compare
Using absl.app causes flags to be handled automatically and gives us nice things like app.UsageError. I've added extra checks for unspecified flags, since otherwise the error messages caused by these flags being unset were quite obtuse. I've removed the default value for --log_list_schema since there is no schema file found at "data/log_list_schema.json". # Conflicts: # python/utilities/log_list/print_log_list.py
RJPercival
force-pushed
the
log_list_app
branch
from
ffb14cd
to
0cd7054
Compare
pphaneuf
reviewed
Sep 7, 2018
| def run(): | ||
|
|
||
| def main(argv): | ||
| del argv # Unused; all arguments provided via flags. |
There was a problem hiding this comment.
Usually, what we do with unused flags like here is name them unused_argv (which shuts up the linter).
There was a problem hiding this comment.
My linter sadly does complain if I name it unused_argv. If I prefix it with an underscore, it's happy though.
pphaneuf
approved these changes
Sep 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using absl.app causes flags to be handled automatically and gives us nice things like
app.UsageError. I've added extra checks for unspecified flags, since otherwise the error messages caused by these flags being unset were quite obtuse.I've removed the default value for
--log_list_schemasince there is no schema file found at "data/log_list_schema.json".