Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting uses of TARGET #124

Closed
tcal-x opened this issue Jun 17, 2021 · 5 comments · Fixed by #132
Closed

Conflicting uses of TARGET #124

tcal-x opened this issue Jun 17, 2021 · 5 comments · Fixed by #132

Comments

@tcal-x
Copy link
Collaborator

tcal-x commented Jun 17, 2021

This is the original message; see also my following replies.

Hi, @alanvgreen :

After some testing with this update, I met a problem. when compile tflm library, it complained no found to "qmtech_wukong_makefile.inc" wihch the board I used is wukong board.

Would you like to share how to solve this problem? or just simple copy the mcu_riscv_makefile.inc to digilet_arty_makefile.inc?

Many thanks.

BR, Akio

Originally posted by @akioolin in #118 (comment)

@tcal-x
Copy link
Collaborator Author

tcal-x commented Jun 17, 2021

My followup comment:

I think I see the issue. It is due to the interaction of this PR and PR #105. #105 added the use of TARGET to specify which LiteX board we're using. This PR causes more of the TFLite-Micro system to be used for generating the build/src/tensorflow/lite/micro/ directory, and that also uses TARGET but for a different purpose. Hopefully the solution is as easy as just unsetting TARGET before calling the TFLM generation.

@tcal-x
Copy link
Collaborator Author

tcal-x commented Jun 17, 2021

To reproduce:

make TARGET=digilent_arty software

output:

/home/tim/google/CFU-Playground/third_party/tflite-micro/tensorflow/lite/micro/tools/make/Makefile:544: tensorflow/lite/micro/tools/make/targets/digilent_arty_makefile.inc: No such file or directory
make[1]: *** No rule to make target 'tensorflow/lite/micro/tools/make/targets/digilent_arty_makefile.inc'.  Stop.
make[1]: Leaving directory '/home/tim/google/CFU-Playground/third_party/tflite-micro'
make: *** [../proj.mk:209: tflite-micro-src] Error 2

@akioolin
Copy link
Contributor

Hi, @tcal-x :

Yes! You are right. CFU is a very young baby, but It will be a Giant in some day.
after some test last night, I found the simple work around way is copy mcu_riscv_makefile.inc to qmtech_wukong_makefile.inc, and the build
process will be continued. the outcome seems work fine.

BR, Akio

@tcal-x tcal-x linked a pull request Jun 19, 2021 that will close this issue
@akioolin
Copy link
Contributor

akioolin commented Jun 19, 2021

Hi, @tcal-x :

after follow PR #132, add the unset into proj.mk.
the build process is very smooth.
Many Thanks.

BR, Akio

@tcal-x
Copy link
Collaborator Author

tcal-x commented Jun 19, 2021

Thanks for reporting the issue, @akioolin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants