Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tflite-micro version #118

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Update tflite-micro version #118

merged 4 commits into from
Jun 16, 2021

Conversation

alanvgreen
Copy link
Collaborator

Updates tflite to use the new tflite-micro git repository. Currently, still only supports a single version. Tested against proj_template, avg_pdti8, proj_accel_1 and mnv2_first with Arty.

#112

With these changes, proj_template will build and run against the new
tflite-micro codebase.

Changes:

- extensive updates to proj.mk to copy TfLM source from a full checkout
  of tflite-micro instead of the tflm_gen directory.
- new submodule for tflite-micro
- updates to tflite.cpp and pdti8.cc to use new example data
- modifications to debug_log and micro_test checked in to common
  directory
Removes two files containing customisations that have been upstreamed.
TfLite micro has changed so that these reinterpret_casts are not needed.
This directory is no longer necessary, as we use
third_party/tflite-micro instead.
@tcal-x
Copy link
Collaborator

tcal-x commented Jun 16, 2021

tflmyay
Yay!

@alanvgreen alanvgreen requested a review from tcal-x June 16, 2021 22:20
Copy link
Collaborator

@tcal-x tcal-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tcal-x tcal-x merged commit e701152 into google:main Jun 16, 2021
@akioolin
Copy link
Contributor

Hi, @alanvgreen :

After some testing with this update, I met a problem. when compile tflm library, it complained no found to "qmtech_wukong_makefile.inc" wihch the board I used is wukong board.

Would you like to share how to solve this problem? or just simple copy the mcu_riscv_makefile.inc to digilet_arty_makefile.inc?

Many thanks.

BR, Akio

@tcal-x
Copy link
Collaborator

tcal-x commented Jun 17, 2021

@akioolin thank you for the report. There has been a lot of restructuring; first, the board-specific .py/.mk files were eliminated in favor of common_soc.py/mk. More recently, @JosephBushagour has added the ability to tailor a board-specific workflow when necessary. We'll try to figure out where things went wrong for the qmtech_wukong.

@tcal-x
Copy link
Collaborator

tcal-x commented Jun 17, 2021

Hi @akioolin , I think I see the issue. It is due to the interaction of this PR and PR #105. #105 added the use of TARGET to specify which LiteX board we're using. This PR causes more of the TFLite-Micro system to be used for generating the build/src/tensorflow/lite/micro/ directory, and that also uses TARGET but for a different purpose. Hopefully the solution is as easy as just unsetting TARGET before calling the TFLM generation.

@alanvgreen alanvgreen deleted the tflite-micro branch July 15, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants