Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sync for private keys? #13

Open
rlipscombe opened this issue Dec 5, 2018 · 4 comments
Open

Disable sync for private keys? #13

rlipscombe opened this issue Dec 5, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@rlipscombe
Copy link

Kinda missing the point of the "private" in "private key" if the key is synchronised to all of my Chrome-using devices.

@iamhsa
Copy link

iamhsa commented Dec 6, 2018

Enable/Disable sync. will be a very interesting option to have.

@ralimi
Copy link
Collaborator

ralimi commented Apr 21, 2019

Seems like a reasonable request.

Until that's implemented, note the following:

  • If an encrypted private key is provided, only the encrypted form is synced.
  • Unencrypted private keys are synced only if an unencrypted private key is provided in the first place.

@rlipscombe
Copy link
Author

rlipscombe commented Apr 21, 2019

Another argument against syncing private keys: I tend to have one key per device, allowing me to revoke a specific key if, say, I leave my laptop in the pub.

Note that this only happened once; the laptop had full disk encryption; and it was closing time anyway, so the laptop was locked up in the pub until I collected it the following day anyway. :)

Still revoked that key, though.

@ralimi ralimi added the enhancement New feature or request label Aug 28, 2022
ralimi added a commit that referenced this issue Sep 4, 2022
This is a first step towards addressing #13, as we currently store session keys and stored keys with the same prefix, and distinguish them only based on which type of storage they are in.  With #13, we will need to have different keys with different purposes concurrently stored in the same type of storage.
@ralimi
Copy link
Collaborator

ralimi commented Sep 4, 2022

To do this, we'll need to migrate some of the data that we store in the browser to a slightly different format. I'm starting to add the plumbing to do that. One that starts, it will take a few releases and some time for that migration to take place safely.

At that point, this should be doable.

ralimi added a commit that referenced this issue Sep 7, 2022
This is a first step towards addressing #13, as we currently store session keys and stored keys with the same prefix, and distinguish them only based on which type of storage they are in.  With #13, we will need to have different keys with different purposes concurrently stored in the same type of storage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants