Add icons

[lavelle]

Both existing providers need an icon to be displayed in the Chrome extensions list, app drawer etc.
My mockup for the S3 one is this:

Which I think is a good direction to go in. The current Google Drive icon in the Files app is the same: The flat grey folder icon with the drive logo in negative space. This one just swaps it out for the S3 logo. However it currently isn't sized correctly (I think icons for Chrome extensions need some padding?). It would be good to get a professional designer to do this. We also might need to get permission to use the S3 logo.

As for WebDAV, it's trickier. The official logo is really ugly:

So it might be better to just have the folder with the word 'DAV' in Roboto in negative space or something similar.

[jmuk]

I only care about the license of the images. If there's no license problems, you can choose anything you want.

[lavelle]

Okay, well I'm not a lawyer but from Amazon's guidelines it looks like we're okay using the logo like this.

As for WebDAV I reckon just go with the word 'DAV' since the official logo is so bad.

If that's all the legal stuff covered, all we need to do is ask a designer to work on them. I could give it a try but I don't have Photoshop on my work machine and it wouldn't look as professional.

[jmuk]

I'm not a lawyer but if the guideline is so, I think that's fine. Also I heard that you drew the s3 icon by yourself. Then, no problem I guess.

For s3, I'm okay with ugly-but-official one, but if you're not, you can draw the icon by yourself.

[jmuk]

Note that AWS SDK's git repository contains the amazon badge https://github.com/aws/aws-sdk-js/blob/master/doc-src/templates/flasky_sphinx_guide/fulldoc/html/img/logo.png licensed under apache-2.0.

[lavelle]

Is there any way to specify separate icons for the Files app and the extension page? If not, I'd like to suggest that as a feature of the manifest.

The greyscale icons within a folder look good in the sidebar of the Files app, but they look kind of bad and also don't make much sense in the extensions list and app launcher. I think it would be better if you could specify a main logo, which would probably be full colour and just the icon, as well as the Files app icon, which is smaller, greyscale and has the icon within a folder icon like Google Drive does already.

I guess if we're going with the plan of making providers extensions instead of packaged apps then a regular display icon won't be necessary, but right now I think you still need to provide a 128px one.

cc @mtomasz-chromium

[lavelle]

I guess I could just have colour icons for 128px and 48px and greyscale folder ones for 32px and 16px.

[jmuk]

I believe an iconset should have the consistent look. Doing 32px and 16px for filesystems UI doesn't sound a good idea.

[lavelle]

But it's more important for icons to be consistent with the other icons around them. All the icons in the Files app are greyscale, and all the icons in the app launcher are full colour.

Think of Google Drive as an analogy. In the app launcher you expect to see this:

But in the Files app you expect to see this:

That's what I've done here: consistent elements, like the S3 logo or the word 'DAV', but different styles for different contexts.

[jmuk]

That sounds like a feature request to fileSystemProvider API. File a bug instead of introducing a hack.

[lavelle]

That's why I CC'ed @mtomasz-chromium, to ask if this feature could be added. I will open a crbug too. The hack was only ever meant to be a temporary solution, in lieu of an official method.

[lavelle]

http://crbug.com/407864

[mtomasz-chromium]

IMHO, real colorful icons should be shown for provided extensions. The icon
should tell users that the file system is provided by an extension with
that specific icon. Drive icon may change in the future in Files app if we
switch to FSP. However, it is not decided, yet.

On 27 August 2014 07:48, Giles Lavelle notifications@github.com wrote:

crbug.com/407864

—
Reply to this email directly or view it on GitHub
#39 (comment)
.

[lavelle]

As per the discussion on the Chromium issue tracker, we will be using full-colour icons in the Files.app too. Do I need to supply 24px as well as 48 for this then?

[jmuk]

You don't have to. IIRC images are automatically resized by Chrome if requested size doesn't exist.