Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-format .travis.yml #111

Merged
merged 1 commit into from Apr 17, 2018
Merged

Re-format .travis.yml #111

merged 1 commit into from Apr 17, 2018

Conversation

campionfellin
Copy link
Collaborator

Adds node_modules to cache, so it won't reinstall unless there are new ones to add.
Removes node versions < 6
Installs and builds before linting/testing
After testing runs coverage report

Signed-off-by: campionfellin campionfellin@gmail.com

Signed-off-by: campionfellin <campionfellin@gmail.com>
@grant grant merged commit 38ef833 into google:master Apr 17, 2018
@campionfellin campionfellin deleted the re-format-travis branch April 17, 2018 05:08
@campionfellin
Copy link
Collaborator Author

Looks like build failed for linux because build starts with rm index.js. Is there a reason we do this? Doesn't it just overwrite it when we run tsc --project tsconfig.json anyway?

@grant
Copy link
Contributor

grant commented Apr 17, 2018

Yes. We should remove rm index.js, as it will always fail.
I did it more for debugging purposes at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants