Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various errors in PR #112 #113

Merged
merged 1 commit into from Apr 17, 2018
Merged

Fix various errors in PR #112 #113

merged 1 commit into from Apr 17, 2018

Conversation

campionfellin
Copy link
Collaborator

This fixes adds the tests folder to .gitignore so it isn't ignored.
Changes uppercaseness of Logs -> logs
Lints the whole project (though only .ts files, so we should probably rewrite tests in typescript)
Specifies mocha test directory (since it isn't default test anymore)
Changes directory from test to tests
Adds no-consecutive-blank-lines rules to tslint.

Signed-off-by: campionfellin campionfellin@gmail.com

Signed-off-by: campionfellin <campionfellin@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 51

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 8.99%

Totals Coverage Status
Change from base Build 50: 1.1%
Covered Lines: 74
Relevant Lines: 610

💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 51

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 8.99%

Totals Coverage Status
Change from base Build 50: 1.1%
Covered Lines: 74
Relevant Lines: 610

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 51

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 8.99%

Totals Coverage Status
Change from base Build 50: 1.1%
Covered Lines: 74
Relevant Lines: 610

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 17, 2018

Pull Request Test Coverage Report for Build 51

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 8.99%

Totals Coverage Status
Change from base Build 50: 1.1%
Covered Lines: 74
Relevant Lines: 610

💛 - Coveralls

@@ -60,6 +60,7 @@
"no-any": false,
"no-arg": true,
"no-conditional-assignment": true,
"no-consecutive-blank-lines": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grant grant merged commit c74b58d into google:master Apr 17, 2018
@grant
Copy link
Contributor

grant commented Apr 17, 2018

Can you be more descriptive in the commit messages? As the project grows bigger, we'll be looking at git blame.

Use the PR description in the commit description:

This fixes adds the tests folder to .gitignore so it isn't ignored.
Changes uppercaseness of Logs -> logs
Lints the whole project (though only .ts files, so we should probably rewrite tests in typescript)
Specifies mocha test directory (since it isn't default test anymore)
Changes directory from test to tests
Adds no-consecutive-blank-lines rules to tslint.

@campionfellin
Copy link
Collaborator Author

Yes, will do. Good point 👍

@campionfellin campionfellin deleted the small-hotfix branch April 17, 2018 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants