-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creates tests for clasp clone and clasp pull #119
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,6 +43,31 @@ describe.skip('Test clasp create function', () => { | |
}); | ||
}); | ||
|
||
// When running this test, please put in a script ID | ||
// then use `sudo npm run build` before running test. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't you need to build before any test? Shouldn't we have this in the file header comment if that is the case? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah good point |
||
describe.skip('Test clasp clone function', () => { | ||
it('should clone an existing project correctly', () => { | ||
spawnSync('rm', ['.clasp.json']); | ||
const result = spawnSync( | ||
'clasp', ['clone', '[SCRIPT_ID]'], { encoding: 'utf8' } | ||
); | ||
expect(result.stdout).to.contain('Cloned'); | ||
expect(result.stdout).to.contain('files.'); | ||
expect(result.status).to.equal(0); | ||
}); | ||
}); | ||
|
||
describe.skip('Test clasp pull function', () => { | ||
it('should pull an existing project correctly', () => { | ||
const result = spawnSync( | ||
'clasp', ['pull'], { encoding: 'utf8' } | ||
); | ||
expect(result.stdout).to.contain('Cloned'); | ||
expect(result.stdout).to.contain('files.'); | ||
expect(result.status).to.equal(0); | ||
}); | ||
}); | ||
|
||
/** | ||
* TODO: Test these commands and configs. | ||
* | ||
|
@@ -54,8 +79,8 @@ describe.skip('Test clasp create function', () => { | |
* [ ] clasp create "myTitle" | ||
* [x] clasp create <untitled> | ||
* [x] clasp list | ||
* [ ] clasp clone <scriptId> | ||
* [ ] clasp pull | ||
* [x] clasp clone <scriptId> | ||
* [x] clasp pull | ||
* [ ] echo '// test' >> index.js && clasp push | ||
* [ ] clasp open | ||
* [ ] clasp deployments | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean "put in a script ID"?
Can we first create a test script ID, then clone it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can do one and hard code it for everyone, if you think that's better. Or use the one from the clasp create test.