Adds more instructions for develop in Readme #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates with clasp login --ownkey Signed-off-by: campionfellin <campionfellin@gmail.com>
2 similar comments
grant
reviewed
Apr 19, 2018
README.md
Outdated
| @@ -213,6 +215,9 @@ clasp <command> | |||
|
|
|||
| #### Run Tests (experimental) | |||
|
|
|||
| Check out `/tests/test.ts` and change `describe.skip(...)` to `describe(...)` for relevant tests. | |||
There was a problem hiding this comment.
Is there a better way to run individual tests?
There was a problem hiding this comment.
Don't say Check out /tests/test.ts\. It's wordy. Accommodate for most people reading this.
I'm guessing if someone searches for this section
90% of people want to run tests.
10% of people want to add a test.
So just state how to run all tests. 1 sentence.
If you find a way to run a single test, you can state that too in 1 sentence/command.
README.md
Outdated
| @@ -213,6 +215,9 @@ clasp <command> | |||
|
|
|||
| #### Run Tests (experimental) | |||
|
|
|||
| Check out `/tests/test.ts` and change `describe.skip(...)` to `describe(...)` for relevant tests. | |||
| If you created a new command, please make a test for it. Here's how to run the tests: | |||
There was a problem hiding this comment.
Delete: If you created a new command, please make a test for it.
We can add this when tests are common and include it somewhere else.
grant
suggested changes
Apr 19, 2018
Signed-off-by: campionfellin <campionfellin@gmail.com>
|
Much better, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates with clasp login --ownkey
Signed-off-by: campionfellin campionfellin@gmail.com