Converts clasp clone to inquirer #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user does clasp clone without a scriptId, it will get the 10 most recent scripts and prompt the user to choose one. Signed-off-by: campionfellin <campionfellin@gmail.com>
Pull Request Test Coverage Report for Build 96
💛 - Coveralls |
grant
approved these changes
Apr 24, 2018
There was a problem hiding this comment.
Great! LGTM.
Before we dive deeper into inquirer, let's create some plans:
- We should abstract out the interface of each method with the implementation
- We might want to take the opportunity to break apart
claspinto multiple files in the next PR.
I know I was resistant to multi-files before, but I think it'd be smart for testing and extensibility.
- Files
src/commands.ts(module.exporteach command as a function)src/utils.ts(settings, OAuth, dotfiles)index.ts(tie everything together)
Like #106, but be sure to not utils.*, just import { DOTFILE } from 'utils.ts';.
Aside, it would be great if each command had a gif (it's not too hard to record): https://giphy.com/apps/giphycapture
index.ts
Outdated
| @@ -218,6 +218,14 @@ const createQuestions = [{ | |||
| default: LOG.UNTITLED_SCRIPT_TITLE, | |||
| }]; | |||
|
|
|||
| // Questions (prompts) for clasp clone | |||
| const cloneQuestions = [{ | |||
There was a problem hiding this comment.
Inline this const to increase locality and reduce the number of identifiers.
grant
suggested changes
Apr 24, 2018
index.ts
Outdated
| const drive = google.drive({version: 'v3', auth: oauth2Client}); | ||
| const res = await drive.files.list({ | ||
| pageSize: 10, | ||
| fields: 'nextPageToken, files(id, name)', |
index.ts
Outdated
| if (!scriptId) { | ||
| getAPICredentials(async () => { | ||
| const drive = google.drive({version: 'v3', auth: oauth2Client}); | ||
| const res = await drive.files.list({ |
index.ts
Outdated
| console.log(err); | ||
| }); | ||
| } else { | ||
| console.log('No script files found.'); |
There was a problem hiding this comment.
No strings in files.
Use LOG.FINDING_SCRIPTS_DNE.
|
Sounds good, quite a few steps there so I'm going to break it into a few issues just for better tracking (in no particular order):
|
Signed-off-by: campionfellin <campionfellin@gmail.com>
|
Changes should be addressed now. |
grant
approved these changes
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user does clasp clone without a scriptId, it will get the 10 most recent scripts and prompt the user to choose one.
Also adds test for this new functionality.
Signed-off-by: campionfellin campionfellin@gmail.com
Goes towards Clasp 2.0
npm run testsucceeds.brings test coverage > %50