Moves spinner and logError to utils #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: campionfellin <campionfellin@gmail.com>
campionfellin
commented
Apr 25, 2018
src/utils.ts
Outdated
| @@ -5,6 +5,8 @@ const splitLines = require('split-lines'); | |||
| import * as fs from 'fs'; | |||
| const dotf = require('dotf'); | |||
| const read = require('read-file'); | |||
| import { Spinner } from 'cli-spinner'; | |||
| import { ERROR } from '../index.js'; | |||
There was a problem hiding this comment.
I'm not a huge fan of importing things into Utils from the main script. I'd rather have ERROR in src/utils.ts or in src/commands and import from there if needed.
There was a problem hiding this comment.
This is creating a cyclic dependency.
Please move the ERRORs into utils.
Pull Request Test Coverage Report for Build 104
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 104
💛 - Coveralls |
Pull Request Test Coverage Report for Build 104
💛 - Coveralls |
grant
suggested changes
Apr 25, 2018
src/utils.ts
Outdated
| @@ -5,6 +5,8 @@ const splitLines = require('split-lines'); | |||
| import * as fs from 'fs'; | |||
| const dotf = require('dotf'); | |||
| const read = require('read-file'); | |||
| import { Spinner } from 'cli-spinner'; | |||
| import { ERROR } from '../index.js'; | |||
There was a problem hiding this comment.
This is creating a cyclic dependency.
Please move the ERRORs into utils.
src/utils.ts
Outdated
| @@ -72,4 +74,32 @@ export const DOTFILE = { | |||
| // See `login`: Stores { accessToken, refreshToken } | |||
| RC: dotf(DOT.RC.DIR, DOT.RC.NAME), | |||
| RC_LOCAL: dotf(DOT.RC.LOCAL_DIR, DOT.RC.NAME), | |||
| }; | |||
|
|
|||
| // Utils | |||
There was a problem hiding this comment.
Remove // Utils, the filename now indicates this.
index.ts
Outdated
| @@ -110,7 +109,7 @@ const LOG = { | |||
| }; | |||
|
|
|||
| // Error messages (some errors take required params) | |||
| const ERROR = { | |||
| export const ERROR = { | |||
There was a problem hiding this comment.
Do not export ERROR in index.ts.
I think LOG and ERROR can be exported in utils.ts despite what I said earlier.
Signed-off-by: campionfellin <campionfellin@gmail.com>
grant
approved these changes
Apr 25, 2018
|
Merge conflict. |
|
Conflict resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing work on #133
Signed-off-by: campionfellin campionfellin@gmail.com
npm run testsucceeds.