Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move getScriptURL, getProjectSettings, and getFileType to utils #142

Merged
merged 1 commit into from Apr 25, 2018
Merged

Move getScriptURL, getProjectSettings, and getFileType to utils #142

merged 1 commit into from Apr 25, 2018

Conversation

campionfellin
Copy link
Collaborator

This continues work on #133

Signed-off-by: campionfellin campionfellin@gmail.com

  • npm run test succeeds.
  • Appropriate changes to README are included in PR.

@campionfellin
Move getScriptURL, getProjectSettings, and getFileType to utils
ebc4839 
Signed-off-by: campionfellin <campionfellin@gmail.com>
@coveralls
Copy link

coveralls commented Apr 25, 2018 •
edited

Pull Request Test Coverage Report for Build 108

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 289 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 11.241%
Files with Coverage Reduction New Missed Lines %
src/utils.js 19 18.45%
index.js 270 6.96%
Totals Coverage Status
Change from base Build 107: 0.2%
Covered Lines: 108
Relevant Lines: 719
💛 - Coveralls

@grant grant merged commit e29e4f3 into google:master Apr 25, 2018
@campionfellin campionfellin deleted the utils branch April 25, 2018 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grant grant grant approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@campionfellin @coveralls @grant @googlebot