Make getProjectSettings async #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just for the functions we have tests for so far... Signed-off-by: campionfellin <campionfellin@gmail.com>
Pull Request Test Coverage Report for Build 131
💛 - Coveralls |
grant
approved these changes
Apr 27, 2018
| logError(error, ERROR.CREATE); | ||
| }); | ||
| } catch (err) { // no scriptId (because project doesn't exist) | ||
| //console.log(err); |
There was a problem hiding this comment.
Looks like a missing err handler.
There was a problem hiding this comment.
Yeah I wasn't sure a great way around this, because the promise should reject (because there shouldn't be a project settings file). So I just catch that and we can figure out a better way to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for the functions we have tests for so far...
Also, put in a quick exit out of
clasp runjust in case anyone tries it.Signed-off-by: campionfellin campionfellin@gmail.com
Works on #146 but doesn't quite finish it...
npm run testsucceeds.npm run lintsucceeds.