Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more items to utils and fix clasp open #153

Merged
merged 1 commit into from Apr 28, 2018
Merged

Move more items to utils and fix clasp open #153

merged 1 commit into from Apr 28, 2018

Conversation

campionfellin
Copy link
Collaborator

Clasp open was trying to open an object, rather than the scriptID
Moved over manifestExists, saveProjectId, checkIfOnline, and getAPIFileType

Signed-off-by: campionfellin campionfellin@gmail.com

Works on #133

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

Clasp open was trying to open an object, rather than the scriptID
Moved over manifestExists, saveProjectId, checkIfOnline, and getAPIFileType

Signed-off-by: campionfellin <campionfellin@gmail.com>
@coveralls
Copy link

coveralls commented Apr 28, 2018

Pull Request Test Coverage Report for Build 134

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 328 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 11.47%

Files with Coverage Reduction New Missed Lines %
src/utils.js 72 14.68%
index.js 256 6.71%
Totals Coverage Status
Change from base Build 133: 0.1%
Covered Lines: 122
Relevant Lines: 793

💛 - Coveralls

@grant grant merged commit 6a52dde into google:master Apr 28, 2018
@grant
Copy link
Contributor

grant commented Apr 28, 2018

Feel free to break up utils, it's getting a bit crazy:

import { DOT, PROJECT_NAME, PROJECT_MANIFEST_BASENAME, ClaspSettings,
    ProjectSettings, DOTFILE, spinner, logError, ERROR, getScriptURL,
    getProjectSettings, getFileType, getAPIFileType, checkIfOnline,
    saveProjectId, manifestExists } from './src/utils.js';

See #134 (comment)

Then again, I think this will change when other files are broken up.

@campionfellin campionfellin deleted the utils branch April 28, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants